[MacPorts] NewCommittersGuide modified
MacPorts
noreply at macports.org
Tue Jun 16 12:44:58 PDT 2009
Changed page "NewCommittersGuide" by blb at macports.org from 75.163.169.166*
Page URL: <http://trac.macports.org/wiki/NewCommittersGuide>
Diff URL: <http://trac.macports.org/wiki/NewCommittersGuide?action=diff&version=19>
Revision 19
Comment: Add piece about whitespace changes needing to be separate
-------8<------8<------8<------8<------8<------8<------8<------8<--------
Index: NewCommittersGuide
=========================================================================
--- NewCommittersGuide (version: 18)
+++ NewCommittersGuide (version: 19)
@@ -11,6 +11,7 @@
1. A command is found to be broken
1. You need to change your email address for your ports
1. Other, similar reasons
+ 1. When changing the whitespace of a Portfile, do so in a separate commit (without any functional changes) as otherwise the commingling of functional and whitespace changes makes reviewing diffs difficult
1. All committers must subscribe to the [http://lists.macosforge.org/mailman/listinfo/macports-changes macports-changes] list under their MacPorts credentials to keep track of current changes and because the list is subscriber-post-only, so commit messages will otherwise be rejected
1. New top-level categories (those which are represented by subdirectories directly beneath dports/) need to be approved prior to adding; secondary categories (the second and later ones listed on the '''categories''' Portfile key) can be added when it makes sense (since these really only show under the web interface, and do not necessarily have a filesystem representation)
1. Make sure the port name matches between the MacPorts svn directory name and the '''name''' Portfile key (while the system works fine when they don't, keeping them synchronized avoids confusing situations)
-------8<------8<------8<------8<------8<------8<------8<------8<--------
* The IP shown here might not mean anything if the user or the server is
behind a proxy.
--
MacPorts <http://www.macports.org/>
Ports system for Mac OS
This is an automated message. Someone at http://www.macports.org/ added your email
address to be notified of changes on NewCommittersGuide. If it was not you, please
report to .
More information about the macports-changes
mailing list