[66297] trunk/base/src/macports1.0/macports.tcl

[raimue at macports.org]

Revision: 66297
          http://trac.macports.org/changeset/66297
Author:   raimue at macports.org
Date:     2010-04-08 15:30:53 -0700 (Thu, 08 Apr 2010)
Log Message:
-----------
macports1.0: Initialize all ui_* at once in mportinit

Using ui_* prior to mportinit might cause unwanted behavior, as channels or
::ui_init might not have been defined yet.

Modified Paths:
--------------
    trunk/base/src/macports1.0/macports.tcl

Modified: trunk/base/src/macports1.0/macports.tcl
===================================================================
--- trunk/base/src/macports1.0/macports.tcl	2010-04-08 20:46:29 UTC (rev 66296)
+++ trunk/base/src/macports1.0/macports.tcl	2010-04-08 22:30:53 UTC (rev 66297)
@@ -242,9 +242,6 @@
             interp alias {} ui_${priority}_${phase} {} ui_message $priority $prefix $phase
         }
     }
-    # Call ui_$priority
-    eval ::ui_$priority $args
-    
 }
 
 # Default implementation of ui_prefix
@@ -302,10 +299,6 @@
     }
 }
 
-foreach priority ${macports::ui_priorities} {
-    proc ui_$priority {args} [subst { eval macports::ui_init $priority \$args }]
-}
-
 proc ui_warn_once {id msg} {
     variable macports::warning_done
     if {![info exists macports::warning_done($id)]} {
@@ -418,6 +411,11 @@
         upvar $up_variations variations
     }
 
+    # Initialize ui_*
+    foreach priority ${macports::ui_priorities} {
+        macports::ui_init $priority
+    }
+
     global auto_path env tcl_platform
     global macports::autoconf::macports_conf_path
     global macports::macports_user_dir
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-changes/attachments/20100408/22b2281f/attachment.html>