[65474] trunk/base/src/cregistry

[raimue at macports.org]

Revision: 65474
          http://trac.macports.org/changeset/65474
Author:   raimue at macports.org
Date:     2010-03-26 08:54:05 -0700 (Fri, 26 Mar 2010)
Log Message:
-----------
cregistry: Remove obsolete TODO, put TODO in right place

Modified Paths:
--------------
    trunk/base/src/cregistry/sql.c
    trunk/base/src/cregistry/vercomp.c

Modified: trunk/base/src/cregistry/sql.c
===================================================================
--- trunk/base/src/cregistry/sql.c	2010-03-26 14:54:38 UTC (rev 65473)
+++ trunk/base/src/cregistry/sql.c	2010-03-26 15:54:05 UTC (rev 65474)
@@ -38,20 +38,6 @@
 #include <sqlite3.h>
 #include <time.h>
 
-/*
- * TODO: maybe this could be made into something that could be separately loaded
- *       by sqlite3? It's a bit hard to query the registry with the command-line
- *       sqlite3 tool because of the missing VERSION collation. My understanding
- *       is that you can make a dylib that can be loaded using an sql statement,
- *       which is less than transparent, but certainly reasonable.
- *
- * TODO: break out rpm_vercomp into a separate file which can be shared by
- *       pextlib and cregistry. The version here is slightly modified so as to
- *       take explicit string lengths. Since these are available in Tcl it's an
- *       easy change and might be a tiny bit faster; it's necessary for the
- *       application here.
- */
-
 /**
  * Executes a null-terminated list of queries. Pass it a list of queries, it'll
  * execute them. This is mainly intended for initialization, when you have a

Modified: trunk/base/src/cregistry/vercomp.c
===================================================================
--- trunk/base/src/cregistry/vercomp.c	2010-03-26 14:54:38 UTC (rev 65473)
+++ trunk/base/src/cregistry/vercomp.c	2010-03-26 15:54:05 UTC (rev 65474)
@@ -39,6 +39,13 @@
 #include <string.h>
 #include <ctype.h>
 
+/*
+ * TODO: share this function between pextlib and cregistry. The version here is
+ *       slightly modified so as to take explicit string lengths. Since these
+ *       are available in Tcl it's an easy change and might be a tiny bit
+ *       faster; it's necessary for the application here.
+ */
+
 /**
  * RPM version comparison. Shamelessly copied from Pextlib, with some changes to
  * use string lengths instead of strlen by default. That's necessary to make it
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-changes/attachments/20100326/2d867404/attachment.html>