[89610] trunk/base/src/port1.0/portlint.tcl

[raimue at macports.org]

Revision: 89610
          http://trac.macports.org/changeset/89610
Author:   raimue at macports.org
Date:     2012-02-03 15:40:39 -0800 (Fri, 03 Feb 2012)
Log Message:
-----------
port1.0/portlint.tcl:
Rewrite check for maintainers; warn when using unobfuscated addresses.

Modified Paths:
--------------
    trunk/base/src/port1.0/portlint.tcl

Modified: trunk/base/src/port1.0/portlint.tcl
===================================================================
--- trunk/base/src/port1.0/portlint.tcl	2012-02-03 23:25:15 UTC (rev 89609)
+++ trunk/base/src/port1.0/portlint.tcl	2012-02-03 23:40:39 UTC (rev 89610)
@@ -496,17 +496,23 @@
         incr errors
     }
 
-    if {[string match "*darwinports at opendarwin.org*" $maintainers]} {
-        ui_warn "Using legacy email address for no/open maintainer"
-        incr warnings
+    foreach addr $maintainers {
+        if {$addr == "nomaintainer at macports.org" ||
+                $addr == "openmaintainer at macports.org"} {
+            ui_warn "Using full email address for no/open maintainer"
+            incr warnings
+        } elseif [regexp "^(.+)@macports.org$" $addr -> name] {
+            ui_warn "Maintainer email address for $name includes @macports.org"
+            incr warnings
+        } elseif {$addr == "darwinports at opendarwin.org"} {
+            ui_warn "Using legacy email address for no/open maintainer"
+            incr warnings
+        } elseif [regexp "^(.+)@(.+)$" $addr -> localpart domain] {
+            ui_warn "Maintainer email address should be obfuscated as $domain:$localpart"
+            incr warnings
+        }
     }
 
-    if {[string match "*nomaintainer at macports.org*" $maintainers] ||
-        [string match "*openmaintainer at macports.org*" $maintainers]} {
-        ui_warn "Using full email address for no/open maintainer"
-        incr warnings
-    }
-
     if {$license == "unknown"} {
         ui_warn "no license set"
         incr warnings
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-changes/attachments/20120203/c0645b9e/attachment.html>