[119615] trunk/base/src/registry2.0

snc at macports.org snc at macports.org
Fri May 2 07:18:04 PDT 2014


Revision: 119615
          https://trac.macports.org/changeset/119615
Author:   snc at macports.org
Date:     2014-05-02 07:18:04 -0700 (Fri, 02 May 2014)
Log Message:
-----------
base: replace eval with expand

Modified Paths:
--------------
    trunk/base/src/registry2.0/portimage.tcl
    trunk/base/src/registry2.0/tests/depends.tcl
    trunk/base/src/registry2.0/tests/entry.tcl

Modified: trunk/base/src/registry2.0/portimage.tcl
===================================================================
--- trunk/base/src/registry2.0/portimage.tcl	2014-05-02 13:56:45 UTC (rev 119614)
+++ trunk/base/src/registry2.0/portimage.tcl	2014-05-02 14:18:04 UTC (rev 119615)
@@ -268,10 +268,10 @@
                 ::file mkdir $dstfile
                 # fix attributes on the directory.
                 if {[getuid] == 0} {
-                    eval ::file attributes {$dstfile} [::file attributes $srcfile]
+                    ::file attributes {$dstfile} {*}[::file attributes $srcfile]
                 } else {
                     # not root, so can't set owner/group
-                    eval ::file attributes {$dstfile} -permissions [::file attributes $srcfile -permissions]
+                    ::file attributes {$dstfile} -permissions {*}[::file attributes $srcfile -permissions]
                 }
                 # set mtime on installed element
                 ::file mtime $dstfile [::file mtime $srcfile]

Modified: trunk/base/src/registry2.0/tests/depends.tcl
===================================================================
--- trunk/base/src/registry2.0/tests/depends.tcl	2014-05-02 13:56:45 UTC (rev 119614)
+++ trunk/base/src/registry2.0/tests/depends.tcl	2014-05-02 14:18:04 UTC (rev 119615)
@@ -6,7 +6,7 @@
     load $pextlibname
 
     # totally lame that file delete won't do it
-	eval exec rm -f [glob -nocomplain test.db*]
+	exec rm -f {*}[glob -nocomplain test.db*]
 
     registry::open test.db
 

Modified: trunk/base/src/registry2.0/tests/entry.tcl
===================================================================
--- trunk/base/src/registry2.0/tests/entry.tcl	2014-05-02 13:56:45 UTC (rev 119614)
+++ trunk/base/src/registry2.0/tests/entry.tcl	2014-05-02 14:18:04 UTC (rev 119615)
@@ -7,7 +7,7 @@
     load $pextlibname
 
     # totally lame that file delete won't do it
-    eval exec rm -f [glob -nocomplain test.db*]
+    exec rm -f {*}[glob -nocomplain test.db*]
 
     # can't create registry in some brain-dead place or in protected place
     test_throws {registry::open /some/brain/dead/place} registry::cannot-init
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/macports-changes/attachments/20140502/d9f0672c/attachment.html>


More information about the macports-changes mailing list