[119695] trunk/base/src/registry2.0/receipt_sqlite.tcl

[cal at macports.org]

Revision: 119695
          https://trac.macports.org/changeset/119695
Author:   cal at macports.org
Date:     2014-05-03 15:46:15 -0700 (Sat, 03 May 2014)
Log Message:
-----------
base: registry2.0/receipt_sqlite.tcl: Use {*} rather than eval

Modified Paths:
--------------
    trunk/base/src/registry2.0/receipt_sqlite.tcl

Modified: trunk/base/src/registry2.0/receipt_sqlite.tcl
===================================================================
--- trunk/base/src/registry2.0/receipt_sqlite.tcl	2014-05-03 22:39:39 UTC (rev 119694)
+++ trunk/base/src/registry2.0/receipt_sqlite.tcl	2014-05-03 22:46:15 UTC (rev 119695)
@@ -195,16 +195,16 @@
 # List all the ports that this port depends on
 proc list_depends {name version revision variants} {
 	set rlist [list]
-	set searchcmd "registry::entry search"
+	set searchkeys {}
     foreach key {name version revision} {
         if {[set $key] ne ""} {
-            append searchcmd " $key [set $key]"
+            lappend searchkeys $key [set $key]
         }
     }
     if {$variants != 0} {
-        append searchcmd " variants {$variants}"
+		lappend searchkeys "variants" $variants
     }
-    if {[catch {set ports [eval $searchcmd]}]} {
+    if {[catch {set ports [registry::entry search {*}$searchkeys]}]} {
         set ports [list]
     }
     foreach port $ports {
@@ -219,16 +219,16 @@
 # List all the ports that depend on this port
 proc list_dependents {name version revision variants} {
 	set rlist [list]
-	set searchcmd "registry::entry search"
+	set searchkeys {}
     foreach key {name version revision} {
         if {[set $key] ne ""} {
-            append searchcmd " $key [set $key]"
+			lappend searchkeys $key [set $key]
         }
     }
     if {$variants != 0} {
-        append searchcmd " variants {$variants}"
+		lappend searchkeys "variants" $variants
     }
-    if {[catch {set ports [eval $searchcmd]}]} {
+    if {[catch {set ports [registry::entry search {*}$searchkeys]}]} {
         set ports [list]
     }
     foreach port $ports {
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/macports-changes/attachments/20140503/b206f876/attachment.html>