[139530] branches/gsoc15-portfile/skel

[chunyang at macports.org]

Revision: 139530
          https://trac.macports.org/changeset/139530
Author:   chunyang at macports.org
Date:     2015-08-19 13:57:19 -0700 (Wed, 19 Aug 2015)
Log Message:
-----------
skel: Fix all warnings reported by --nitpick option

Modified Paths:
--------------
    branches/gsoc15-portfile/skel

Modified: branches/gsoc15-portfile/skel
===================================================================
--- branches/gsoc15-portfile/skel	2015-08-19 20:52:46 UTC (rev 139529)
+++ branches/gsoc15-portfile/skel	2015-08-19 20:57:19 UTC (rev 139530)
@@ -25,22 +25,24 @@
     # "port lint" also checks these fields' values.
     set fields(PortSystem) 1.0
     set fields(platforms) darwin
+    set fields(version) 2.0
 }
 
 proc build_portfile {} {
-    global fields
+    global fields skel_required_variables
 
     set modeline "# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4"
     set svn_id_tag_line "# \$Id\$"
 
     puts $modeline
     puts $svn_id_tag_line
+    puts {}
 
-    # NOTE: the order of iterating assoc array in this clean way is not
-    # predictable, it can be resolved by using $skel_required_variables, but
-    # it's fine for now since "port lint" seems to be unable to check order.
-    foreach {name val} [array get fields] {
-        puts [format "%-20s%s" $name $val]
+    foreach name $skel_required_variables {
+        puts [format "%-20s%s" $name $fields($name)]
+        if {$name eq "PortSystem"} {
+            puts {}
+        }
     }
 }
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/macports-changes/attachments/20150819/6322039f/attachment.html>