[142588] trunk/base/src/port1.0/portlint.tcl
ryandesign at macports.org
ryandesign at macports.org
Sat Dec 12 06:23:36 PST 2015
Revision: 142588
https://trac.macports.org/changeset/142588
Author: ryandesign at macports.org
Date: 2015-11-16 06:14:43 -0800 (Mon, 16 Nov 2015)
Log Message:
-----------
portlint.tcl: add lint warning when using eval procedure instead of expansion operator
Modified Paths:
--------------
trunk/base/src/port1.0/portlint.tcl
Modified: trunk/base/src/port1.0/portlint.tcl
===================================================================
--- trunk/base/src/port1.0/portlint.tcl 2015-11-16 14:13:14 UTC (rev 142587)
+++ trunk/base/src/port1.0/portlint.tcl 2015-11-16 14:14:43 UTC (rev 142588)
@@ -294,6 +294,14 @@
incr errors
}
+ if {[regexp {(^.*)(\meval\s+)(.*)(\[glob\M)(.*$)} $line -> match_before match_eval match_between match_glob match_after]} {
+ ui_warn "Line $lineno should use the expansion operator instead of the eval procedure. Change"
+ ui_warn "$line"
+ ui_warn "to"
+ ui_warn "$match_before$match_between{*}$match_glob$match_after"
+ incr warnings
+ }
+
# Check for hardcoded version numbers
if {$nitpick} {
# Support for skipping checksums lines
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/macports-changes/attachments/20151212/35fcb36d/attachment.html>
More information about the macports-changes
mailing list