[31795] trunk/dports/security

[Eric Hall]

On Fri, Dec 07, 2007 at 03:35:54PM -0600, Ryan Schmidt wrote:
> Some comments...
> 
> On Dec 7, 2007, at 13:12, ricci at macports.org wrote:
> 
> >Added: trunk/dports/security/afflib/Portfile
> >===================================================================
> >--- trunk/dports/security/afflib/Portfile	                         
> >(rev 0)
> >+++ trunk/dports/security/afflib/Portfile	2007-12-07 19:12:12 UTC  
> >(rev 31795)
> >@@ -0,0 +1,55 @@
> >+# $Id$
> >+
> >+PortSystem 1.0
> 
> There should be a newline after this line; see "port lint" (in  
> MacPorts 1.6.0 and later).
> 
> >+name		afflib
> >+version		3.0.4
> >+revision	0
> 
> 0 is the default revision; you don't need to specify it.

	I like to have it there so that if there is a rev bump, the
line is already there.

> 
> >+categories	net
> 
> The port is in the "security" directory but says its category is  
> "net"? That doesn't match.

	copy + paste + don't fix typo

> 
> >+maintainers	opendarwin.org at darkart.com
> >+description	The Advanced Forensic Format
> >+homepage	http://afflib.org/
> 
> Probably "homepage http://www.aflib.org/" would have been better  
> since "http://afflib.org/" redirects to that.
> 
> >+platforms	darwin
> >+
> >+long_description AFF(R) is an open and extensible file format  
> >designed \
> >+			to store disk images and associated metadata.
> >+
> >+master_sites	http://www.afflib.org/downloads/
> 
> Then you could just say "master_sites ${homepage}downloads/" here.
> 
> >+checksums	md5	60730870a313056ae85aa489141714e7		\
> >+		sha1	6b17e3297fb6825e3748a8f4aef6065b77a69291
> >+##		rmd160	dd5a0bb35bf27c2c16794580a6e9861fffe78ccc
> 
> Why is the rmd160 checksum commented out?


	Because I don't have the best possible verification that
the distfile that I have is valid.

> 
> >+use_bzip2	no
> 
> The default is not to use bzip2; you don't need to specify it.

	Yup, and if that changes this Portfile is protected.

> 
> >+## depends_lib	port:libewf	\
> 
> Why is this dependency commented out?

	Because I was lazy and didn't re-gen my PortIndex while testing,
and then forgot to fix before I committed (clearly I'm not 100% on today).


> 
> >+depends_lib	\
> >+		port:openssl	\
> >+		port:readline	\
> >+		port:zlib
> >+
> >+configure.args	--enable-fuse=no	\
> >+		--enable-s3=no		\
> >+		--with-ssl=${prefix}	\
> >+		--with-zlib=${prefix}
> 
> There's extra whitespace after this line, which "port lint" also  
> mentions.
> 
> >+variant s3 description { Enable the use of Amazon's S3 service } {
> >+	configure.args-append	--enable-s3=yes	\
> >+				--with-curl=${prefix}/lib
> >+	configure.args-delete	--enable-s3=no
> >+	depends_lib-append	port:curl	\
> >+				port:expat
> >+}
> >+
> >+
> >+## untested....
> >+## variant fuse description { Access AFF data through FUSE } {
> >+## 	configure.args-append	--enable-fuse=yes
> >+## 	configure.args-delete	--enable-fuse=no
> >+## 	
> 
> Extra white space after this line.
> 
> >+## }
> >+##
> >+
> >+#
> >+##EOF
> 
> We all know where the end of the file is; you don't need a comment  
> for that. :)
> 

	Ancient habituation.


	Similar explaintions for the libewf Portfile.

	I'll check out 'port lint' and clean those up.  I may also
succeed in beating the afflib auto* foo into shape so it does what
I want, otherwise I'll just commit the small fixes.


		-eric