One commit = one change

Vincent Lefevre vincent-opdarw at vinc17.org
Mon Mar 5 18:28:11 PST 2007


On 2007-03-05 19:27:05 -0600, Ryan Schmidt wrote:
> For example, if you want to change the indentation of the file, do  
> only that, then commit it, with a log message that says you're  
> changing the whitespace.

Some changes will also change the indentation as a consequence
(well, perhaps more rarely in Portfiles than in C code...). That's
why diff (and Subversion, via -x) has the -w option to ignore all
white space change in diffs.

> http://trac.macports.org/projects/macports/changeset/22515
> 
> The whitespace of most of the file was changed, the maintainer was  
> changed, the configure args were changed, and some patches were  
> added,

You can see it more or less as a complete rewrite. There were
outdated things and options that probably should never been used
(but no comments saying why they were added).

> though it doesn't say why or what issue they were supposed to  
> fix.

Just look at the MPFR web site. The full description of what the
patches fix would be a bit too much for the log file (IMHO, MacPorts
lacks ChangeLog support).

BTW, what homepage should be? The home page of the software or the
home page of the particular version of the software?

-- 
Vincent Lefèvre <vincent at vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / Arenaire project (LIP, ENS-Lyon)



More information about the macports-dev mailing list