[31193] branches/release_1_6/base/src

[Ryan Schmidt]

On Nov 17, 2007, at 23:09, jmpp at macports.org wrote:

> Revision: 31193
>           http://trac.macosforge.org/projects/macports/changeset/31193
> Author:   jmpp at macports.org
> Date:     2007-11-17 21:09:01 -0800 (Sat, 17 Nov 2007)
>
> Log Message:
> -----------
>
> Temporarily revert Landon's hiding of the Tcl cd command until  
> remaining Portfiles are cleaned up.
> Currently there are still almost 300 ports that use the command and  
> breaking them all in one fell
> swoop is not something we want to do!

Thanks. That's a relief.

I'm working on a new script to give us a better indicator of how many  
ports are affected (and to show where). My complicated grep was  
inaccurate, markd pointed out, in that it gave false positives for  
(several) portfiles which used "cd" inside of ui_msg blocks, as  
instructions to the user, which should not be flagged as a problem.

> One thing we should do is find a way to issue a suitable warning  
> when Tcl's cd is called from a Portfile
> but not from port1.0, as that would be useless information.

An excellent idea. Much like we currently get notices about mtree  
violations.