Updating a Portfile

[Jonathan Strine]

Thanks for the clarification.  I have created a new trac ticket with  
the updated Portfile (#12737).  Commit at your convenience.

Thanks!

--
Jonathan Strine
PGP Key ID:  0x0A02201C


On Sep 18, 2007, at 3:45 PM, Daniel J. Luke wrote:

> On Sep 18, 2007, at 2:44 PM, Jonathan Strine wrote:
>> A recent port I submitted (dynamips-0.2.7) needs a minor update to  
>> compile correctly for the no_pcap variant and on powerpc  
>> platforms.  Should I increment the revision number on my  
>> Portfile?  Or should I keep the revision at 0 since it is a minor  
>> change that doesn't require an upgrade if you already have  
>> dynamips installed?
>
> The general rule is that if the change changes the files that end  
> up being installed, then you want to bump the revision.
>
> It's also often useful to bump it whenever you make a bugfix (as  
> it's easy for the end user to see if they have the latest portfile  
> or not).
>
> However, it sometimes makes sense to make a change and not bump the  
> revision. I suppose if on ppc +no_pcap didn't end up installing  
> anything at all, it might be OK to not bump the revision.
>
> Or to summarize, it's largely up to the maintainer to decide, but  
> it's generally more useful to bump it than not to.
> --
> Daniel J. Luke
> +========================================================+
> | *---------------- dluke at geeklair.net ----------------* |
> | *-------------- http://www.geeklair.net -------------* |
> +========================================================+
> |   Opinions expressed are mine and do not necessarily   |
> |          reflect the opinions of my employer.          |
> +========================================================+
>
>