[36031] trunk/dports/devel/bugzilla/Portfile

[William Siegrist]

On Apr 16, 2008, at 9:03 AM, Ryan Schmidt wrote:
>> post-patch {
>> -	cd ${worksrcpath}
>> +	system "cd ${worksrcpath}"
>> 	foreach item [exec find . -type f -name .cvsignore] {
>> 		file delete -force ${item}
>> 	}
>> @@ -99,7 +107,7 @@
>>
>> 	set docPath "${prefix}/share/doc/${name}"
>> 	xinstall -d -m 0755 ${destroot}${docPath}
>> -	cd ${worksrcpath}
>> +	system "cd ${worksrcpath}"
>> 	xinstall -m 0644 \
>> 		README QUICKSTART UPGRADING UPGRADING-pre-2.8 \
>> 		${destroot}${docPath}/
>
> That change isn't going to work, is it? I mean, the reason why the  
> tcl "cd" command was deprecated is because we don't want portfiles  
> changing the working directory. Using 'system "cd"' won't change the  
> working directory, so e.g. the subsequent tcl "file delete" commands  
> won't find the files to delete. To fix the post-patch phase, you'd  
> have to "exec find ${worksrcpath} ..." instead. Haven't looked at  
> the second bit.
>
>


Thanks for catching that and explaining it. The correct fix wasnt  
clear to me so I tried to match what some other ports were doing.

Please see my fix in r36065 and let me know if there's anything else I  
missed.

-Bill








-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2421 bytes
Desc: not available
Url : http://lists.macosforge.org/pipermail/macports-dev/attachments/20080416/e6ff3031/smime.bin