[36148] trunk/dports/aqua/dnsupdate/Portfile

[Joshua Root]

Ryan Schmidt wrote:
> On Apr 19, 2008, at 8:55 AM, jmr at macports.org wrote:
> 
>> Revision: 36148
>>           http://trac.macosforge.org/projects/macports/changeset/36148
>> Author:   jmr at macports.org
>> Date:     2008-04-19 06:55:13 -0700 (Sat, 19 Apr 2008)
>>
>> Log Message:
>> -----------
>> dnsupdate: avoid symlink creation failure
>>
>> Modified Paths:
>> --------------
>>     trunk/dports/aqua/dnsupdate/Portfile
>>
>> Modified: trunk/dports/aqua/dnsupdate/Portfile
>> ===================================================================
>> --- trunk/dports/aqua/dnsupdate/Portfile    2008-04-19 12:16:32 UTC 
>> (rev 36147)
>> +++ trunk/dports/aqua/dnsupdate/Portfile    2008-04-19 13:55:13 UTC 
>> (rev 36148)
>> @@ -91,7 +91,7 @@
>>      xinstall -d -m 0755 ${destroot}${itemPath}
>>      xinstall -d -m 0755 ${itemAliasPath}
>>      xinstall -m 0755 ${worksrcpath}/org.dnsupdate.daemon.plist 
>> ${destroot}${itemPath}/${itemName}
>> -    file link -symbolic ${itemAliasPath}/${itemName} 
>> ${itemPath}/${itemName}
>> +    system "ln -s ${itemPath}/${itemName} ${itemAliasPath}/${itemName}"
> 
> Could you explain in more detail what's going on with this change? I 
> would think we would want to be using the tcl "ln" procedure, not 
> calling out to a shell command with system, so I'm interested in why you 
> decided to change *to* using system.

The link being created points to a path that does not (yet) exist. 'file 
link -symbolic' worked when I tested the port on Leopard, but failed 
when I just recently tried installing it on Tiger. 'ln -s' works on both 
OS versions.

- Josh