[43346] trunk/dports/net/network-weathermap/Portfile

[markd at macports.org]

>> @@ -40,9 +40,15 @@
>>       reinplace "s|/usr/local/|/opt/local/|g" \
>>               ${worksrcpath}/weathermap \
>>               ${worksrcpath}/weathermap-cacti-rebuild.php
>> +
>> +# Set perl location
>> +     reinplace "s|/usr/bin/perl|/opt/local/bin/perl|g" \
>> +             ${worksrcpath}/random-bits/auto-overlib.pl
>>  }
>
>This perl location change seems unrelated,

That change should have been in the commit comments too, but I forgot.  Or
are you saying the reinplace should have been in a separate commit from
the file delete one?

> and also not correct since
>you're hard-coding /opt/local instead of using ${prefix}.
>
>Actually the port already hardcodes /opt/local in another reinplace
>above, so that needs to be fixed too.

I must have been caffeine deprived.  I fixed those in r43416.  Thanks for
catching that.

>You also
>need a runtime dependency on path:bin/perl:perl5 then.

The rrdtool port depends on perl, so I didn't think it necessary to repeat
it.  Though sometimes I do anyway in these cases.  Not sure what the rule
is, or the best practice either.  If you think the perl one should be
there anyway I can add it.

Mark