[43649] trunk/dports/x11/gtk2/Portfile

[Ryan Schmidt]

On Dec 12, 2008, at 16:52, jeremyhu at macports.org wrote:

> Revision: 43649
>           http://trac.macports.org/changeset/43649
> Author:   jeremyhu at macports.org
> Date:     2008-12-12 14:52:30 -0800 (Fri, 12 Dec 2008)
> Log Message:
> -----------
> gtk2: Reduce the gtk2 X11 dependencies since some of them are  
> actually optional... Maybe we shold make some variants for the  
> optional X11 extensions?

Ports should build with maximal functionality by default, unless this  
is inconvenient due to the number or size of the needed dependencies.  
Variants should be added sparingly where truly needed.


> Modified Paths:
> --------------
>     trunk/dports/x11/gtk2/Portfile
>
> Modified: trunk/dports/x11/gtk2/Portfile
> ===================================================================
> --- trunk/dports/x11/gtk2/Portfile	2008-12-12 22:51:49 UTC (rev 43648)
> +++ trunk/dports/x11/gtk2/Portfile	2008-12-12 22:52:30 UTC (rev 43649)
> @@ -130,11 +130,15 @@
>
>  variant x11 conflicts quartz description {Enable rendering in X11  
> (default)} {
>      depends_lib-append \
> -        lib:libXrandr.2:xorg-libXrandr \
> -        lib:libXcursor.1:xorg-libXcursor \
> -        lib:libXfixes.3:xorg-libXfixes \
>          lib:libXi.6:xorg-libXi
>
> +        # These are optional dependencies... variants?
> +        #lib:libXrandr.2:xorg-libXrandr \
> +        #lib:libXcursor.1:xorg-libXcursor \
> +        #lib:libXdamage.1:xorg-libXdamage \
> +        #lib:libXcomposite.1:xorg-libXcomposite \
> +        #lib:libXfixes.3:xorg-libXfixes \
> +

If gtk2 will automatically find and use these libraries if present,  
then gtk2 either needs to declare dependencies on the libraries, or  
it needs to use configure arguments or other strategies to ensure it  
does not use those libraries even if they are present.