[43775] trunk/dports/audio/mpg123/Portfile

[Neil]

On Wed, Dec 24, 2008 at 4:12 PM, Bryan Blackburn <blb at macports.org> wrote:
> On Wed, Dec 24, 2008 at 03:40:17PM -0600, Ryan Schmidt said:
>>
>> On Dec 14, 2008, at 15:17, jmr at macports.org wrote:
>>
>>> Revision: 43775
>>>           http://trac.macports.org/changeset/43775
>>> Author:   jmr at macports.org
>>> Date:     2008-12-14 13:17:09 -0800 (Sun, 14 Dec 2008)
>>> Log Message:
>>> -----------
>>> mpg123: platform 'powerpc' -> 'ppc'
>>>
>>> Modified Paths:
>>> --------------
>>>     trunk/dports/audio/mpg123/Portfile
>>>
>>> Modified: trunk/dports/audio/mpg123/Portfile
>>> ===================================================================
>>> --- trunk/dports/audio/mpg123/Portfile       2008-12-14 18:52:09 UTC (rev
>>> 43774)
>>> +++ trunk/dports/audio/mpg123/Portfile       2008-12-14 21:17:09 UTC (rev
>>> 43775)
>>> @@ -27,6 +27,6 @@
>>>      configure.args-append --with-cpu=x86
>>>  }
>>>
>>> -platform macosx powerpc {
>>> +platform macosx ppc {
>>>      configure.args-append --with-cpu=altivec
>>>  }
>>
>>
>> We have 60 occurrences of something like "platform powerpc" in the ports
>> tree and only 8 occurrences of something like "platform ppc"...... Do both
>> work? The Guide only shows "powerpc".
>
> port [1] and portmain [2] both convert "Power Macintosh" to powerpc, for
> os_arch.  Seems like powerpc is the one and those using ppc should be
> changed.  If there's some places where it will report ppc instead, shouldn't
> we change that to powerpc as well?
>
> Bryan
>
> [1] - <http://trac.macports.org/browser/trunk/base/src/port/port.tcl#L1723>
> [2] - <http://trac.macports.org/browser/trunk/base/src/port1.0/portmain.tcl#L86>
>
>
>>
>> http://guide.macports.org/#reference.variants.platform
>>

I suspect you'll find 'ppc' to be more intuitive to users, however.