[34062] trunk/dports/tex/bibutils/Portfile

[Ryan Schmidt]

On Feb 11, 2008, at 13:45, Jochen Küpper wrote:

> On 11.02.2008, at 20:27, ryandesign at macports.org wrote:
>
>> bibutils: fix doubled slash in homepage URL introduced in r34060
>> Modified Paths
>> 	• trunk/dports/tex/bibutils/Portfile
>> Diff
>> Modified: trunk/dports/tex/bibutils/Portfile (34061 => 34062)
>> --- trunk/dports/tex/bibutils/Portfile	2008-02-11 18:53:36 UTC  
>> (rev 34061)
>> +++ trunk/dports/tex/bibutils/Portfile	2008-02-11 19:27:46 UTC  
>> (rev 34062)
>> @@ -17,7 +17,7 @@
>>                      filters.
>>
>>  master_sites        http://www.scripps.edu/~cdputnam/software/ 
>> bibutils/
>> -homepage            ${master_sites}/bibutils.html
>> +homepage            ${master_sites}bibutils.html
>
> Where actually is the problem with the double slash? I find my  
> committed version (including the slash) *much* easier to read!

The URL of our Trac installation is not:

http://trac.macports.org///projects/////macports/

That URL does not work. The correct URL is:

http://trac.macports.org/projects/macports/


Similarly, the URL of the bibutils homepage is not:

http://www.scripps.edu/~cdputnam/software/bibutils//bibutils.html

Although that URL does work, that's probably not the URL we should be  
advertising (via e.g. "port info"). The correct URL is:

http://www.scripps.edu/~cdputnam/software/bibutils/bibutils.html


There is an RFC (sorry I forget the number, but it's the one about  
how a URL is put together) which states that the path component of a  
URL can't have two slashes next to one another. So either MacPorts  
base or the portfile itself should take care to construct correct  
valid URLs without doubled slashes in the path component. Currently  
MacPorts base has no code to strip out doubled slashes from the path  
component, so portfiles themselves should do this.


In a previous discussion of this topic I believe Markus Weissmann  
also said that he found it easier to read with the extra slash in the  
portfile, and favored the solution where MacPorts base would strip  
the doubled slashes from the path component of homepage,  
livecheck.url and all master_sites. But I don't see why we should  
introduce this kind of magic. Why should MacPorts base second-guess  
the portfile author? Also, someone reading such a portfile might then  
be confused. Where did the extra slash go?


Bottom line: we should either modify MacPorts base to remove doubled  
slashes from the path component of URLs, or we should add a port lint  
warning for such URLs. I'm in favor of a port lint warning.