[38055] trunk/dports/lang/swi-prolog/Portfile

[Ryan Schmidt]

On Jul 4, 2008, at 13:20, gwright at macports.org wrote:

> Revision: 38055
>           http://trac.macosforge.org/projects/macports/changeset/38055
> Author:   gwright at macports.org
> Date:     2008-07-04 11:20:46 -0700 (Fri, 04 Jul 2008)
> Log Message:
> -----------
> Version bump to 5.6.57.
>
> Modified Paths:
> --------------
>     trunk/dports/lang/swi-prolog/Portfile
>
> Modified: trunk/dports/lang/swi-prolog/Portfile
> ===================================================================
> --- trunk/dports/lang/swi-prolog/Portfile	2008-07-04 18:17:29 UTC  
> (rev 38054)
> +++ trunk/dports/lang/swi-prolog/Portfile	2008-07-04 18:20:46 UTC  
> (rev 38055)
> @@ -3,7 +3,7 @@
>  PortSystem	1.0
>
>  name		swi-prolog
> -version		5.6.55
> +version		5.6.57
>  epoch		20051223
>
>  categories	lang
> @@ -25,19 +25,21 @@
>  homepage	http://www.swi-prolog.org/
>  master_sites	http://gollem.science.uva.nl/cgi-bin/nph-download/SWI- 
> Prolog/
>
> -checksums	md5     5710bc10a72a285a4cdf55924b6987e0
> +checksums	md5     c41709e50dbcd784f26273a1686af9e8 \
> +		sha1    30c1e45dbe1d8d963599059394a8fa3228c8fbca \
> +		rmd160  3c5a699b4528cb1272c6ba77acceb17bf5ba8703
>
>  depends_build   \
>  	port:gawk	\
>  	port:junit
>
>  depends_lib		\
> -	port:readline				\
> +	port:readline			\
>  	lib:libncursesw:ncurses		\
> -	lib:libjpeg:jpeg			\
> +	lib:libjpeg:jpeg		\
>  	lib:libmcrypt:libmcrypt		\
>  	lib:libX11.6:XFree86		\
> -	lib:libgmp:gmp				\
> +	lib:libgmp:gmp			\
>  	lib:libzlib:zlib

There isn't a "libzlib" (it's called "libz"). But you should use  
port:-style dependencies anyway, not lib:-style (except for  
lib:libX11.6:XFree86 which should stay as it is so that it can use  
Apple's X11 instead of XFree86). For the other dependencies, we  
always want the MacPorts versions used, never another version the  
user might have installed.

>  platform darwin 6 {
> @@ -51,19 +53,19 @@
>  distname	pl-${version}
>
>  configure.env	\
> -	LIBRARY_PATH=/usr/lib:/usr/X11R6/lib:${prefix}/lib 		\
> +	LIBRARY_PATH=/usr/lib:/usr/X11R6/lib:${prefix}/lib 	\
>  	CPATH=/usr/include:/usr/X11R6/include:${prefix}/include	\

Should use ${x11prefix} instead of hardcoding /usr/X11R6.

I'm not clear on why LIBRARY_PATH and CPATH are needed here. /usr/lib  
and /usr/include are surely already there by default. And MacPorts  
already puts -L${prefix}/lib into LDFLAGS and -I${prefix}/include  
into CPPFLAGS which should serve the same purpose. Maybe all you need  
to do is add -L${x11prefix}/lib to LDFLAGS and -I${x11prefix}/include  
to CPPFLAGS (using configure.ldflags-append and configure.cppflags- 
append). I have not tested this however.

>  	JUNIT=${prefix}/share/java/junit.jar
>
>  configure.ldflags

Ah, I see, you're deleting the LDFLAGS here. If you found that to be  
necessary, then very well.

>  configure.args	\
> -	--prefix=${prefix}				\
> +	--prefix=${prefix}		\

Do not need to have --prefix=${prefix} in the configure.args because  
it is already in the configure.pre_args by default. This applies to  
swi-prolog-lite too.

>  	--mandir=${prefix}/share/man	\
>  	--with-world
>
>  build.env	\
> -	LIBRARY_PATH=/usr/lib:/usr/X11R6/lib:${prefix}/lib		\
> +	LIBRARY_PATH=/usr/lib:/usr/X11R6/lib:${prefix}/lib	\
>  	CPATH=/usr/include:/usr/X11R6/include:${prefix}/include	\

Same comment as for configure.env above. You may want to just set  
build.env to configure.env to save yourself from having to duplicate  
this information.