[38707] trunk/dports/databases

[Ryan Schmidt]

On Jul 29, 2008, at 20:08, Ryan Schmidt wrote:

> On Jul 29, 2008, at 04:52, mr_bond at macports.org wrote:
>
>> Revision: 38707
>>           http://trac.macosforge.org/projects/macports/changeset/ 
>> 38707
>> Author:   mr_bond at macports.org
>> Date:     2008-07-29 02:52:47 -0700 (Tue, 29 Jul 2008)
>> Log Message:
>> -----------
>> pgbouncer: New port submission, pgbouncer 1.1.2. Closes #16044
>>
>> Added Paths:
>> -----------
>>     trunk/dports/databases/pgbouncer/
>>     trunk/dports/databases/pgbouncer/Portfile
>>
>> Added: trunk/dports/databases/pgbouncer/Portfile
>> ===================================================================
>> --- trunk/dports/databases/pgbouncer/ 
>> Portfile	                        (rev 0)
>> +++ trunk/dports/databases/pgbouncer/Portfile	2008-07-29 09:52:47  
>> UTC (rev 38707)
>> @@ -0,0 +1,35 @@
>> +# $Id$
>> +
>> +PortSystem 1.0
>> +
>> +name			pgbouncer
>> +version			1.1.2
>> +categories		databases
>> +platforms		darwin
>> +maintainers		mac.com:giorgio_v
>> +description		Lightweight connection pooler for PostgreSQL
>> +long_description	pgbouncer is a PostgreSQL connection pooler. \
>> +			Any target application can be connected to \
>> +			pgbouncer as if it were a PostgreSQL server, \
>> +			and pgbouncer will manage to connect to the \
>> +			server, or to reuse one of its existing	connections.
>> +
>> +homepage		http://pgbouncer.projects.postgresql.org/
>> +master_sites		http://pgfoundry.org/frs/download.php/1532/
>> +checksums		md5 47bde1402f1a99dfc69f2f610fc1a36c \
>> +			sha1 2b3c9a3c6ea620d2e35d4c857592e54afb5c727c \
>> +			rmd160 7f2b4364c575109d3a59a909494029f80b542b2c
>> +
>> +configure.env		PATH=$env(PATH):${prefix}/lib/postgresql83/bin
>> +
>> +depends_build		port:postgresql83
>> +depends_lib             port:libevent
>> +
>> +livecheck.check	regex
>> +livecheck.url	http://pgfoundry.org/frs/?group_id=1000258
>> +livecheck.regex	pgbouncer-(\[0-9\\.\]+)\\.tar\\.gz
>> +
>> +variant postgresql82 description {uses postgresql82 installation} {
>> +	depends_build		port:postgresql82
>> +	configure.env		PATH=$env(PATH):${prefix}/lib/postgresql82/bin
>> +}
>
> If a user selects the postgresql82 variant, pgbouncer will depend  
> on both postgresql82 and postgresql83 which is probably not what  
> you want.

Sorry, I realize I was mistaken on this point. The rest of my  
feedback stands however.

> When you have two possibilities which would be represented as radio  
> buttons in a GUI as opposed to checkboxes (as is the case here --  
> the choice between postgresql82 and postgresql83) you should have  
> two variants, marked as conflicting with one another, with one  
> being the default. This makes it clearer to the user what her  
> choices are.
>
> Attached is a diff.
>
> I'm also surprised postgresql* is listed as a build dependency.  
> It's not needed at runtime? If it is, you should make it a run  
> dependency, not a build dependency.