[38683] trunk/base/src/port1.0/resources/group

[Caspar Florian Ebeling]

On Thu, Jul 31, 2008 at 9:08 AM, Ryan Schmidt <ryandesign at macports.org> wrote:
> On Jul 28, 2008, at 16:21, febeling at macports.org wrote:
>> Added: trunk/base/src/port1.0/resources/group/tests/ruby-1.0.tcl
>> ===================================================================
>> --- trunk/base/src/port1.0/resources/group/tests/ruby-1.0.tcl
>>                (rev 0)
>> +++ trunk/base/src/port1.0/resources/group/tests/ruby-1.0.tcl   2008-07-28
>> 21:21:33 UTC (rev 38683)
>> @@ -0,0 +1,148 @@
>> +#!/bin/sh
>> +# start as tcl \
>> +exec tclsh "$0" "$@"
>> +
>> +set prefix                    /opt/local
>
> Is it necessary to hardcode /opt/local here or could the actual MacPorts
> prefix be somehow determined?
>
> Also, although you define the ${prefix} variable here, you use /opt/local
> four subsequent times in the script. Shouldn't ${prefix} be used in those
> cases too?

Yeah, I will change it to something like dirname(which port).
Or maybe I mock away the whole ruby port dependence of the
test. That would be a still nicer option, but also complicates the
test further. I think about it.

Florian




-- 
Florian Ebeling
florian.ebeling at gmail.com