Pre-commit script to reject commits

Rainer Müller raimue at macports.org
Fri Mar 7 09:58:28 PST 2008


Blair Zajac wrote:
> I was thinking that we should have a pre-commit script reject commits if a 
> portfile does not increment a revision or version if it changes any of its 
> depends_*.  I find this pretty annoying to see commits that add a dependency 
> that don't bump a version or revision.

I don't see why changing depends_* should change the revision. Either it 
prevented the installation at all or users installed the dependency by 
hand before. It doesn't change the files which are going to be 
installed. Incrementing the revision would force them to do an 
unnecessary recompile.

The only thing I can think of is that the output of `port dependents' 
could be 'wrong'. But that's reflecting the state of the port as it was 
installed, so it is kind of correct.

Rainer


More information about the macports-dev mailing list