[35256] trunk/base/src/port1.0/portdistfiles.tcl

[William Siegrist]

I already committed the changes to port.tcl, port.1, and the Makefile  
earlier.

The point of the command is to let a post-commit script parse it when  
a Portfile is committed. The mirror target does mostly what I want,  
but I did want to avoid fetching all of these files into the server's  
$prefix. I could go move the files after the mirror stage of course,  
but I wanted some separation and a little more control over the  
fetching. (Like not fetching a file we already have). I dont remember  
anyone mentioning the mirror target either when we discussed distfile  
mirroring, so I did overlook this. Maybe I will just extend mirror  
with some options for alternate destinations and such. I'll have to  
see how easy that will be.

The other benefit I thought distfiles would add is portfile devs could  
get a list of files/urls that fetch would use. Thats probably not  
terribly useful, but its something that didnt exist before?

Thanks for catching my oversight though.

-Bill




On Mar 24, 2008, at 2:41 AM, Rainer Müller wrote:
> wsiegrist at apple.com wrote:
>> Revision: 35256
>>          http://trac.macosforge.org/projects/macports/changeset/35256
>> Author:   wsiegrist at apple.com
>> Date:     2008-03-22 15:18:17 -0700 (Sat, 22 Mar 2008)
>> Log Message:
>> -----------
>> added checksum display and an early exit when master_sites is not  
>> provided
>> Modified Paths:
>> --------------
>>    trunk/base/src/port1.0/portdistfiles.tcl
>
> Just that you are aware of it, there is already a `port mirror` target
> which may do the same or similar things. Maybe it could just be
> extended? I want to note this to avoid code duplication or something
> like this...
>
> Also, I think you forgot to add 'distfiles' to the action_array in
> port/port.tcl. Otherwise it will not be usable with `port distfiles`.
>
> Rainer
>
> PS: Sorry for sending this twice, Bill. I used an not subscribed  
> email address...




----
William Siegrist
Software Support Engineer
Mac OS Forge
http://macosforge.org/
wsiegrist at apple.com
408 862 7337





-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2421 bytes
Desc: not available
Url : http://lists.macosforge.org/pipermail/macports-dev/attachments/20080324/4557fae4/attachment.bin