[36971] trunk/dports/sysutils/freeradius/Portfile

[Ryan Schmidt]

On May 21, 2008, at 09:50, andrea.damore at macports.org wrote:

> Revision: 36971
>           http://trac.macosforge.org/projects/macports/changeset/36971
> Author:   andrea.damore at macports.org
> Date:     2008-05-21 07:50:21 -0700 (Wed, 21 May 2008)
>
> Log Message:
> -----------
> freeradius update to 2.0.4

Thanks for the update! See some suggestions below...


> -version          1.1.7
> +version          2.0.4
>  revision         1

When you increase a port's version, you should drop the revision down  
to 0, or you can remove the revision line altogether which will have  
the same effect.


> -master_sites     ftp://ftp.freeradius.org/pub/radius/ \
> +use_bzip2	yes
> +distname	${name}-server-${version}
> +master_sites     ftp://ftp.freeradius.org/pub/freeradius/ \
>  		 ftp://ftp.freeradius.org/pub/radius/old
> -checksums        sha1 4e8515f82260478ef881ed7b87b7ca258e19ccba
> +checksums	\
> +			freeradius-server-2.0.4.tar.bz2 \
> +				md5  0b63d1d75e51bd94b62c11c639fa329e \
> +				sha1  3408d09a990c63df6718939097650a463d654a99 \
> +				rmd160  66915fb5511573b502b7afdb96fd0adb807faa29

You don't need to repeat the distfile name in the checksum section if  
it's of the default form (${distname}${extract.suffix}) and there's  
only one distfile. I'd suggest removing this redundant information  
from all your ports as well, where possible, to keep them simpler.


> -destroot.destdir prefix=${destroot}${prefix}
> +destroot.env-append	R=${destroot}
> +#destroot.destdir prefix=${destroot}${prefix}

You should generally remove lines no longer needed, not comment them  
out. If you need to refer to the line later, you can always look up  
the older version of the portfile in the Subversion repository.