[36898] trunk/dports/net

[Ryan Schmidt]

On May 17, 2008, at 13:09, mr_bond at macports.org wrote:

> Log Message:
> -----------
> New port sumbission, dynamips version 0.2.8-RC2 (required for GNS3)

Thanks for the port! Some suggestions:

> Added Paths:
> -----------
>     trunk/dports/net/dynamips-devel/
>     trunk/dports/net/dynamips-devel/Portfile
>     trunk/dports/net/dynamips-devel/files/
>     trunk/dports/net/dynamips-devel/files/patch-Makefile
>
> Added: trunk/dports/net/dynamips-devel/Portfile
> ===================================================================
> --- trunk/dports/net/dynamips-devel/ 
> Portfile	                        (rev 0)
> +++ trunk/dports/net/dynamips-devel/Portfile	2008-05-17 18:09:24  
> UTC (rev 36898)
> @@ -0,0 +1,52 @@
> +# $Id$
> +
> +PortSystem 1.0
> +
> +name		dynamips-devel
> +version		0.2.8-RC2
> +revision	1

The initial revision of a version of a port should be 0, not 1. Don't  
change it now, but keep it in mind for future updates.

> +configure {}

Could you please use "use_configure no" instead of "configure {}"?  
Thanks.