Typo in dp2mp-move code in dmg preflight

Ryan Schmidt ryandesign at macports.org
Tue Nov 11 20:44:50 PST 2008


On Nov 11, 2008, at 21:56, Bryan Blackburn wrote:

> On Tue, Nov 11, 2008 at 06:46:00PM -0600, Ryan Schmidt said:
>> Do we have a typo here?
>>
>> http://trac.macports.org/browser/trunk/base/portmgr/dmg/preflight?
>> rev=32397#L47
>>
>> [ ! -d /opt/local/share/darwinports ] || rm -rf /opt/local/ 
>> darwinports
>>
>> Shouldn't that be
>>
>> [ ! -d /opt/local/share/darwinports ] || rm -rf /opt/local/share/
>> darwinports
>
> Looks like it to me, though at this stage I hope nobody's still  
> running DP.

Fixed in r41907. Though few should still have dp installed,  
presumably anyone who has been upgrading since dp will still have  
that directory around, which this fix will cause to now be properly  
removed.

> If I recall, some paths may have been changed around a bit, but I  
> can't
> remember if it was stuff under share or var...

You mean, other things have changed a bit, after the dp2mp rename?



More information about the macports-dev mailing list