[42000] trunk/dports/x11/gtk2-murrine-configurator

[Ryan Schmidt]

On Nov 13, 2008, at 16:48, Bryan Blackburn wrote:

> On Thu, Nov 13, 2008 at 10:51:50PM +0100, nox said:
>
>> Le 13 nov. 08 à 22:38, Ryan Schmidt a écrit :
>>
>>> On Nov 13, 2008, at 07:32, nox at macports.org wrote:
>>>
>>>> -    reinplace -E "s|/usr/bin/env python|${prefix}/bin/ 
>>>> python2.5|" \
>>>> -        ${worksrcpath}/src/newmurrineconfigurator.py
>>>> +    reinplace -E s|@PREFIX@|$prefix| \
>>>> +        $worksrcpath/src/newmurrineconfigurator.py
>>>
>>> Just out of curiosity, why are you in the habit lately of  
>>> removing the
>>> braces from variables?  We've been using braces around variables  
>>> almost
>>> everywhere in MacPorts for a long time... why change now?
>>
>> Got the habit writing shell scripts, does it bother you? I can  
>> lose this
>> habit if you want.
>
> ${variable} works in shell scripts too; while only needed when other
> variable-valid characters follow, it definitely isn't hurting  
> things, though
> if it is your port, it's your choice.

While I know the braces aren't necessary, they have been our style,  
so for consistency I'd like to keep them. I also find it helps me to  
visually spot variables more easily when I'm skimming Portfiles.