[42158] trunk/dports/lang/llvm/Portfile

[Bryan Blackburn]

On Sun, Nov 16, 2008 at 02:25:08AM -0600, Ryan Schmidt said:
> On Nov 16, 2008, at 01:13, erickt at macports.org wrote:
>
>> Revision: 42158
>>           http://trac.macports.org/changeset/42158
>> Author:   erickt at macports.org
>> Date:     2008-11-15 23:13:33 -0800 (Sat, 15 Nov 2008)
>> Log Message:
>> -----------
>> Adding a pic option to llvm from {17268}. Thanks Arto!
>
> In the future it would be best not to increment the revision unless  
> rebuilding the port will result in different files being installed on the 
> user's system. In this case, no existing users have the pic variant 
> because it did not exist before, so forcing everyone to rebuild is not 
> necessary, and doesn't gain anyone anything.
>
> I'm also curious to know: for what reason might I want to use this  
> variant? What is position-independent code and why might I want or not 
> want it?

I'd like to know if there's any reason why it can't be part of the default
build instead of being a variant.  Position-independent code (PIC) is
basically code which can be relocated in memory which is what's used by
shared libraries and such.  Note that on Mac OS X, PIC is the default case
when using gcc, and since the Mac really likes dynamic libraries over
static, PIC would make more sense.

Bryan


>
>
>> Modified Paths:
>> --------------
>>     trunk/dports/lang/llvm/Portfile
>>
>> Modified: trunk/dports/lang/llvm/Portfile
>> ===================================================================
>> --- trunk/dports/lang/llvm/Portfile	2008-11-16 06:51:29 UTC (rev 42157)
>> +++ trunk/dports/lang/llvm/Portfile	2008-11-16 07:13:33 UTC (rev 42158)
>> @@ -4,6 +4,7 @@
>>
>>  name                    llvm
>>  version                 2.4
>> +revision                1
>>  categories              lang
>>  platforms               darwin
>>  use_parallel_build      yes
>> @@ -57,3 +58,7 @@
>>          }
>>      }
>>  }
>> +
>> +variant pic description {Enable generation of position independent  
>> code} {
>> +    configure.args-append --enable-pic
>> +}
>