[42296] trunk/dports/databases/db46/Portfile

[nox]

Le 18 nov. 08 à 15:55, nottwo at macports.org a écrit :

> Revision42296Authornottwo at macports.orgDate2008-11-18 06:55:20 -0800  
> (Tue, 18 Nov 2008)Log Message
> Add variant that builds db_dump185.  Closes #16301
> Modified Paths
> 	• trunk/dports/databases/db46/Portfile
> Diff
> Modified: trunk/dports/databases/db46/Portfile (42295 => 42296)
> --- trunk/dports/databases/db46/Portfile	2008-11-18 14:51:39 UTC  
> (rev 42295)
> +++ trunk/dports/databases/db46/Portfile	2008-11-18 14:55:20 UTC  
> (rev 42296)
> @@ -51,12 +51,21 @@
>  		move ${destroot}${prefix}/bin/db_${bin} \
>  			${destroot}${prefix}/bin/db46_${bin}
>  	}
> +
> +        if { [ variant_isset dump185 ] } {
> +            move ${destroot}${prefix}/bin/db_dump185 \
> +                ${destroot}${prefix}/bin/db46_dump185
> +        }
>  }
>
>  variant java description {Enable java bindings} {
>  	configure.args-append --enable-java
>  }
>
> +variant dump185 description {Build db_dump185 tool} {
> +        configure.args-append --enable-dump185
> +}
> +
>  livecheck.check regex
>  livecheck.url   http://www.oracle.com/technology/documentation/berkeley-db/db/ref/changelog/4.6.html
>  livecheck.regex {Berkeley DB (\d+(?:\.\d+)*)}
One question and a little suggestion:
Why a variant for this small utility?
Instead of testing whether the variant is set, you could write another  
post-destroot block in the variant itself.