MacPorts 1.7.1 milestone created

[Bryan Blackburn]

On Thu, Nov 27, 2008 at 12:26:40AM +0100, Rainer Müller said:
> Bryan Blackburn wrote:
> > On Wed, Nov 26, 2008 at 06:05:54PM +0100, Rainer Müller said:
> >> Last thing we have not decided on is how to name the resources
> >> directory. I wanted to use .resources to make a clear difference to port
> >> categories and to prevent portindex recursing there, but there was a
> >> concern about using hidden directories. So I would be fine with using
> >> _resources and let portindex ignore directories starting with an underscore.
> > 
> > I don't see any problem with .resources, these are all files which are
> > included by port when needed (mirror_sites and the various port groups).
> > Most people aren't messing around with them so visibility isn't that big a
> > deal, and we don't have to add code to portindex/mporttraverse/ReaddirCmd()
> > to skip it.
> 
> I just did a check and portindex actually does parse directories
> starting with a dot. So it does not matter if we name it .resources or
> _resources. Also, as long as we do not have any "Portfile" in resources,
> we could also delay changes to portindex/mporttraverse to 1.7.1.

Hmm, so it does; my original test created one too many subdirs.  Note that
we would actually just need to avoid .resources/subdir/Portfile as just
.resources/Portfile is ignored, as is .resources/subdir/subdir2/Portfile (my
original test).

And I'd say the update would be needed in mporttraverse since that'll get
anything trying to access multiple Portfiles, instead of putting the check
in portindex.  Though it looks like the change may be as simple as adding

   if {[string index $category 0] == "."} {continue}

This would skip any dot files/directories (including .svn for those of us
with svn instead of rsync repos).

Bryan


> 
> Rainer