[42693] trunk/dports/x11/xrender/Portfile

[Ryan Schmidt]

On Nov 29, 2008, at 13:43, jeremyhu at macports.org wrote:

> Revision: 42693
>           http://trac.macports.org/changeset/42693
> Author:   jeremyhu at macports.org
> Date:     2008-11-29 11:43:06 -0800 (Sat, 29 Nov 2008)
> Log Message:
> -----------
> Much needed update to libXrender

Indeed. Thank you!

> Modified Paths:
> --------------
>     trunk/dports/x11/xrender/Portfile
>
> Modified: trunk/dports/x11/xrender/Portfile
> ===================================================================
> --- trunk/dports/x11/xrender/Portfile	2008-11-29 19:15:44 UTC (rev  
> 42692)
> +++ trunk/dports/x11/xrender/Portfile	2008-11-29 19:43:06 UTC (rev  
> 42693)
> @@ -3,47 +3,47 @@
>  PortSystem			1.0
>
>  name				xrender
> -set my_name         libXrender
> -version				0.9.0
> -revision            3
> +set my_name			libXrender
> +version				0.9.4
> +revision			1

For future reference, note that the first revision of a particular  
version of a port should be 0, not 1; you can simply delete the  
revision line to achieve this. Don't change it now, but do keep it in  
mind for future updates.


>  configure.env \
> -    RENDER_CFLAGS=-I${prefix}/include \
> -    RENDER_LIBS=-L${prefix}/lib
> +    CPPFLAGS=-I${prefix}/include -I${x11prefix}/include \
> +    LDFLAGS=-L${prefix}/lib -L${x11prefix}/lib \
> +    PKG_CONFIG_PATH=${x11prefix}/lib/pkgconfig

Note that CPPFLAGS and LDFLAGS should not be put into the environment  
manually like this, but instead like this:

configure.cppflags-append -I${x11prefix}/include
configure.ldflags-append -L${x11prefix}/lib

-I${prefix}/include is already in the CPPFLAGS by default, and -L$ 
{prefix}/lib is already in the LDFLAGS by default, so you just need  
to append the new values.

And you shouldn't need to put ${x11prefix}/lib/pkgconfig into the  
PKG_CONFIG_PATH because it's already set properly for you as of two  
weeks ago; see:

http://trac.macports.org/ticket/16993