[41229] trunk/dports/science

[Frank Schima]

Hi Ryan,


On Oct 29, 2008, at 2:07 AM, Ryan Schmidt wrote:

> On Oct 28, 2008, at 15:17, macsforever2000 at macports.org wrote:
>
>> +distfiles        fastcap-${version}wr
>> +worksrcdir       fastcap-${version}wr
>
> For both fastcap and fasthenry, it's weird that you're downloading a  
> distfile file with no extension at all. They have a file with the  
> usual .tar.gz extension so that would be preferable. The attached  
> patch fixes it.
>
> <fast1.diff>

and

>> +destroot {
>> +    xinstall -m 755 ${worksrcpath}/bin/busgen ${destroot}${prefix}/ 
>> bin
>> +    xinstall -m 755 ${worksrcpath}/bin/capgen ${destroot}${prefix}/ 
>> bin
>> +    xinstall -m 755 ${worksrcpath}/bin/cubegen ${destroot}$ 
>> {prefix}/bin
>> +    xinstall -m 755 ${worksrcpath}/bin/fastcap ${destroot}$ 
>> {prefix}/bin
>> +    xinstall -m 755 ${worksrcpath}/bin/pipedgen ${destroot}$ 
>> {prefix}/bin
>> +    xinstall -m 755 ${worksrcpath}/bin/pyragen ${destroot}$ 
>> {prefix}/bin
>
> You can simplify the destroot of fastcap and fasthenry by installing  
> all binaries in a single xinstall command. See attached patch.
>
> <fast2.diff>

Changed in r41263 and r41264. Thanks!


Cheers!
Frank

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-dev/attachments/20081029/5dcef359/attachment.html>