[49606] trunk/base/src/port1.0/portactivate.tcl

Rainer Müller raimue at macports.org
Tue Apr 14 13:55:42 PDT 2009


Perry Lee wrote:
> On Apr 13, 2009, at 1:00 AM, Ryan Schmidt wrote:
>>> Revision: 49606
>>>          http://trac.macports.org/changeset/49606
>>> Author:   perry at macports.org
>>> Date:     2009-04-13 00:40:18 -0700 (Mon, 13 Apr 2009)
>>> Log Message:
>>> -----------
>>> port1.0/portactivate.tcl - Wrap notes output to the terminal's width.
>> We already have the wrapline procedure to do this (added in r34354).  
>> Could this be used here as well, instead of having another separate  
>> line wrapping implementation?
> 
> I mentioned that in the ticket http://trac.macports.org/ticket/421#comment 
> :17.
> 
> I'm not sure if there's a way to share the proc since it's in  
> port.tcl, but I thought it'd be better to commit it now so at least  
> the output looks more uniform than what I had before.

I am not sure if it is really the appropriate place in port1.0 to make
changes for the output device. For example, there could be COLUMNS in
the environment even if the actual client is a GUI where we don't know
how it handles ui_*.

macports1.0 let's you register different Tcl channels for each ui_*
command. Thinking of other clients, e.g. the MacPorts.framework it may
be more correct to wrap the ui_msgs in port/port.tcl.

But this would require to write our own Tcl channel for port/port.tcl
which I did not look into yet. Maybe it would be easier to have simple
callbacks instead of Tcl channels, but probably the person implementing
this as channels had something in mind which I do not see yet.

Rainer


More information about the macports-dev mailing list