editors/sigil

[Ryan Schmidt]

On Aug 10, 2009, at 08:57, krischik at macports.org wrote:

> Revision: 55419
>           http://trac.macports.org/changeset/55419
> Author:   krischik at macports.org
> Date:     2009-08-10 06:57:38 -0700 (Mon, 10 Aug 2009)
> Log Message:
> -----------
> Sigil, the ePub editor


> Modified: trunk/dports/editors/sigil/Portfile
> ===================================================================
> --- trunk/dports/devel/gnat-xmlada/Portfile	2009-06-30 11:53:09 UTC  
> (rev 53153)
> +++ trunk/dports/editors/sigil/Portfile	2009-08-10 13:57:38 UTC  
> (rev 55419)

sigil doesn't seem to be related at all to gnat-xmlada, so it's  
confusing that you created this port by "svn cp"ing that one.


> +master_sites	    googlecode:sigil

This can be simplified to

master_sites googlecode


> +distfiles	    Sigil_code_${version}.zip
> +worksrcdir	    Sigil_code_${version}/src

This can be simplified to

distname Sigil_code_${version}
worksrcdir ${distname}/src

Although, in the configure phase below, I see you want to be outside  
the src directory. So it might be more straightforward to leave  
worksrcpath at its default of ${distname} and set build.dir to $ 
{worksrcpath}/src instead.

Then again, you don't appear to want to be in the src directory in  
the build phase either; there, you're in the build directory. So,  
when is it that you want to be in the src directory?


>  use_configure	    yes

This is the default; you don't need to state it.


> +configure {
> +    system "
> +	if test ! -x /opt/local/bin/qmake ; then
> +	    ln -s /opt/local/libexec/qt4-mac/bin/qmake /opt/local/bin;
> +	fi;
> +	mkdir -p ${workpath}/build;
> +	pushd ${workpath}/build;
> +	    cmake -G \"Unix Makefiles\" ${workpath}/${worksrcdir}/Sigil;
> +	popd;
> +    "
>  }


> +build {
> +    system "
> +	pushd ${workpath}/build;
> +	    typeset -x LIBRARY_PATH=/opt/local/lib;
> +	    gmake Sigil;
> +	popd;
> +    "
> +}


Is there a reason you're doing things in bash here instead of tcl?

It looks like you're creating a symlink at ${prefix}/bin/qmake,  
outside of the destroot. Ports should not create files outside the  
destroot like this.

Since you're using cmake and gmake to build, you should declare build  
dependencies on the cmake and gmake ports.


On Aug 10, 2009, at 09:29, krischik at macports.org wrote:

> Revision: 55422
>           http://trac.macports.org/changeset/55422
> Author:   krischik at macports.org
> Date:     2009-08-10 07:29:30 -0700 (Mon, 10 Aug 2009)
> Log Message:
> -----------
> a few /opt/local slipped in again


> Modified: trunk/dports/editors/sigil/Portfile


> @@ -49,7 +49,7 @@
>  build {
>      system "
>  	pushd ${workpath}/build;
> -	    typeset -x LIBRARY_PATH=/opt/local/lib;
> +	    typeset -x LIBRARY_PATH=${prefix};
>  	    gmake Sigil;
>  	popd;
>      "

Did you mean to replace /opt/local/lib with ${prefix} here? Or should  
it be ${prefix}/lib?