Shouldn't arch flags also go in LDFLAGS?

Ryan Schmidt ryandesign at macports.org
Tue Dec 8 15:34:01 PST 2009


On Dec 8, 2009, at 17:27, Joshua Root wrote:

> On 2009-12-9 10:11 , Ryan Schmidt wrote:
> 
>> Port pure wasn't respecting build_arch properly. In discussing this with the developer of pure, I told him MacPorts puts the arch flags in CFLAGS and CPPFLAGS, and he explained that we should also be putting them in LDFLAGS [1]. I notice the muniversal portgroup and the regular universal variant both do this when building universal. Is there any reason base should not also do so when not building universal?
> 
> <http://lists.macosforge.org/pipermail/macports-dev/2009-November/010789.html>

Thanks, I read that before but it obviously didn't stick in my brain. :)

So it looks like this has been fixed in trunk in r60662 and r60680. (I should test that with pure without the patch.)

There's several things I still want to merge back to the 1.8 branch for hopefully a 1.8.2 release soon. Any reason I couldn't merge these as well?




More information about the macports-dev mailing list