[62001] trunk/dports/python

[Ryan Schmidt]

On Dec 27, 2009, at 07:48, krischik at macports.org wrote:

> Revision: 62001
>          http://trac.macports.org/changeset/62001
> Author:   krischik at macports.org
> Date:     2009-12-27 05:48:29 -0800 (Sun, 27 Dec 2009)
> Log Message:
> -----------
> Python modules needed for calibre.


> Property changes on: trunk/dports/python/py26-clientform
> ___________________________________________________________________
> Added: svn:ignore
>   + .backups
> work

I suggest you add ".backups" and "work" to your Subversion client's global ignores; it's not efficient to add the svn:ignore property to every port directory in the repository.


> Modified: trunk/dports/python/py26-clientform/Portfile
> ===================================================================
> --- trunk/dports/python/py25-clientform/Portfile	2009-12-26 11:54:37 UTC (rev 61972)
> +++ trunk/dports/python/py26-clientform/Portfile	2009-12-27 13:48:29 UTC (rev 62001)
> @@ -1,36 +1,37 @@
> -# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- 
> # $Id$
> +# vim: set fileencoding=utf-8 tabstop=8 shiftwidth=4 softtabstop=4 noexpandtab filetype=tcl :

It would be better to use the standard modeline defined in the Guide.

http://guide.macports.org/chunked/development.creating-portfile.html


> -PortSystem 1.0
> -PortGroup python25 1.0
> +PortSystem	    1.0
> +PortGroup python26  1.0
> 
> -name                py25-clientform
> -version             0.2.9
> -categories          python www
> -platforms           darwin
> -maintainers         openmaintainer akitada
> -description         python module for handling HTML forms
> +name		    py26-clientform
> +version		    0.2.9
> +categories	    python www
> +platforms	    darwin
> +maintainers	    openmaintainer krischik
> +description	    python module for handling HTML forms

When there are multiple ports for a single piece of software (e.g. py25-something and py26-something) they should be kept as similar as possible. This means not making whitespace or functional changes to one without making the same changes to the other. If I look at a diff between the py25 and py26 versions of a port, I should only see the necessary functional differences.

You changed the ports from space-only indentation to a mix of tab and space indentation; we want spaces only. See the Guide:

http://guide.macports.org/chunked/development.practices.html#development.practices.portstyle

It's also best if these ports are maintained (or co-maintained) by the same mainatiner(s) (though having openmaintainer is fine and allows either maintainer to update the other port).