[46149] trunk/dports

[Ryan Schmidt]

Martin, please note my comments below:


On Jan 30, 2009, at 10:52, krischik at macports.org wrote:

> Revision: 46149
>           http://trac.macports.org/changeset/46149
> Author:   krischik at macports.org
> Date:     2009-01-30 08:52:45 -0800 (Fri, 30 Jan 2009)
> Log Message:
> -----------
> O dear - nrg4iso is of course a sysutil and not an emulator. It is  
> in fact a better nrg2iso.
>
> Modified Paths:
> --------------
>     trunk/dports/sysutils/nrg4iso/Portfile
>
> Added Paths:
> -----------
>     trunk/dports/sysutils/nrg4iso/
>
> Removed Paths:
> -------------
>     trunk/dports/emulators/nrg4iso/
>
> Property Changed:
> ----------------
>     trunk/dports/sysutils/nrg4iso/Portfile
>
>
> Property changes on: trunk/dports/sysutils/nrg4iso
> ___________________________________________________________________
> Added: svn:ignore
>    + .backups

We don't use a directory called ".backups" so there's no need to add  
such an svn:ignore property. If you personally use a directory of  
that name in the course of your work, you should add it to your  
Subversion client's global-ignores instead.


> Added: svn:mergeinfo
>    +
>
> Modified: trunk/dports/sysutils/nrg4iso/Portfile
> ===================================================================
> --- trunk/dports/emulators/nrg4iso/Portfile	2009-01-30 13:13:42 UTC  
> (rev 46146)
> +++ trunk/dports/sysutils/nrg4iso/Portfile	2009-01-30 16:52:45 UTC  
> (rev 46149)
> @@ -5,9 +5,10 @@
>
>  name				nrg4iso
>  version				1.0.1
> +revision			1

Unless your changes cause different files to be installed on the  
user's system, you should not increase the revision. You shouldn't  
decrease it again now, but keep it in mind for future changes.

>  platforms			darwin
> -categories			emulators
> -maintainers			me.com:krischik
> +categories			sysutils
> +maintainers			macports:macports.org

The correct maintainer address would be "macports.org:krischik" or  
just "krischik". I fixed this in r47113.

> Property changes on: trunk/dports/sysutils/nrg4iso/Portfile
> ___________________________________________________________________
> Modified: svn:keywords
>    - Id
>    + Author Date Id Revision HeadURL
> Modified: svn:eol-style
>    - native
>    + LF
> Added: svn:executable
>    + *
> Added: svn:mime-type
>    + text/x-shellscript

A portfile is not a shell script and is not executable. Note also  
that we use svn:eol-style native and svn:keywords Id. We don't use  
the other keywords you added. You may wish to set your Subversion  
client's auto-props to automatically add the correct svn:eol-style  
and svn:keywords to portfiles. I fixed the properties in r47112.