[45273] trunk/dports/math

[Ryan Schmidt]

On Jan 12, 2009, at 11:24, devans at macports.org wrote:

> --- trunk/dports/math/libqalculate/Portfile	                         
> (rev 0)
> +++ trunk/dports/math/libqalculate/Portfile	2009-01-12 17:24:14 UTC  
> (rev 45273)
[snip]
> +depends_lib	port:cln\
> +		port:libxml2\
> +		port:glib2\
> +		lib:libreadline:readline

Should always use MacPorts readline, so this should be  
"port:readline" and then make sure the port actually does use  
MacPorts readline.


> --- trunk/dports/math/qalculate-gtk/ 
> Portfile	                        (rev 0)
> +++ trunk/dports/math/qalculate-gtk/Portfile	2009-01-12 17:24:14  
> UTC (rev 45273)
[snip]
> +variant yelp description {Provides GUI help via yelp} {
> +	depends_run-append	port:yelp\
> +				port:libgnome
> +}

A variant must do more than just add a dependency. It must also  
instruct the software (e.g. via a configure argument) that it is ok  
to use these extra libraries. Or put another way: the software must  
not attempt to use these libraries if this variant is not selected,  
even if those libraries were coincidentally already installed.