[45614] trunk/base/src/port1.0/portdestroot.tcl

[Ryan Schmidt]

On Jan 18, 2009, at 19:27, Rainer Müller wrote:

> Ryan Schmidt wrote:
>>> @@ -101,6 +102,8 @@
>>>      file mkdir "${destroot}"
>>>      if { ${os.platform} == "darwin" } {
>>>          system "cd \"${destroot}\" && ${mtree} -e -U -f [file join
>>> ${portsharepath} install macosx.mtree]"
>>> +        file mkdir "${destroot}/${applications_dir}"
>>> +        file mkdir "${destroot}/${frameworks_dir}"
>>>      }
>>>      file mkdir "${destroot}/${prefix}"
>>>      system "cd \"${destroot}/${prefix}\" && ${mtree} -e -U -f
>>> [file join ${portsharepath} install prefix.mtree]"
>>
>> They don't need slashes between them, though, do they?
>
> I was not sure if it would be okay to leave the slashes out, but as
> there is a slash between ${destroot} and ${prefix} a few lines below I
> added them.
>
> Probably we could leave it out in all cases, as we always expect
> ${applications_dir}, ${frameworks_dir} and ${prefix} to be absolute
> paths starting with a slash, right?

Right. There should never be a slash before ${prefix}, $ 
{applications_dir} or ${frameworks_dir}, anywhere in MacPorts base or  
in any Portfile, because those variables always begin with a slash.