universal_variant no not being honored?

[Joshua Root]

On 2009-7-5 10:34, Jeremy Huddleston wrote:
> 
> On Jul 4, 2009, at 15:53, Bryan Blackburn wrote:
> 
>> On Sat, Jul 04, 2009 at 03:24:53PM -0700, Jeremy Huddleston said:
>>> samba3 has 'universal_variant no' set, but it looks like it's still
>>> trying to build universal (I'm using base trunk):
>>
>> Just tried it here, and only see
>>
>> Using FLAGS      =  -pipe -O2 -arch i386 -fno-common -O
>> -D_SAMBA_BUILD_=3 -fno-common
>> -I/mp/var/macports/build/_Users_blb_devel_macports_trunk_dports_net_samba3/work/samba-3.2.12/source/iniparser/src
>> -Iinclude -I./include  -I. -I. -I./lib/replace -I./lib/talloc
>> -I./lib/tdb/include -I./libaddns -I./librpc -DHAVE_CONFIG_H 
>> -I/mp/include -DHAVE_STRUCT_TIMESPEC -Iinclude -I./include -I. -I.
>> -I./lib/replace -I./lib/talloc -I./lib/tdb/include -I./libaddns
>> -I./librpc -I./popt -DLDAP_DEPRECATED   -I/include
>> -I/mp/var/macports/build/_Users_blb_devel_macports_trunk_dports_net_samba3/work/samba-3.2.12/source/lib
>> -D_SAMBA_BUILD_=3
>>
>> My universal_archs is set to 'ppc i386' so it doesn't seem to be picking
>> that up; my install is also trunk, last installed a little over 12 hours
>> ago.  Do you have any of samba3's dependencies installed +universal? 
>> Maybe
>> it's getting some CFLAGS from one of those?
> 
> Nope, it's definitely getting CFLAGS from base.  I switched it over to
> muniversal, and it's now building correctly. (did you try it before I
> pushed the muniversal change or after?)

Might have been a bug in portconfigure that I just tried to fix. It was
checking [variant_isset universal], but a variant can be set without
existing in the port. Now it checks with variant_exists as well.

But... this is still a problem. If you look at configure.cflags before
you declare the universal variant (like in all ports that use the
default one, for instance), you don't see the universal_cflags in there.
And if you append to cflags in the same place, the universal flags never
get added.

Might have to go back to appending them in the variant so they at least
get in there by configure time.

- Josh