ryandesign at macports.org
Tue Jul 21 14:16:06 PDT 2009
On Jul 21, 2009, at 13:19, toby at macports.org wrote:
> Revision: 54124
> Author: toby at macports.org
> Date: 2009-07-21 11:19:39 -0700 (Tue, 21 Jul 2009)
> Log Message:
> remove faulty Xcode version check (#20382)
I reverted this change in r54132. I had deliberately added this code
4 months ago; see #18801 .
Do not remove code others have deliberately added to portfiles
without discussing the issue first.
Do not modify maintained ports without giving the maintainer 72 hours
to respond to the issue. The maintainer probably never even saw this
ticket since it wasn't assigned to him and he was not Cc'd. If the
maintainer timeout policy is too restrictive we can discuss whether
it needs to be changed. Perhaps we need to add exemptions for certain
kinds of changes.
The reason I reverted your change is that this check is in over a
dozen other ports too and we need a fix that addresses all ports, not
just tiff. I would like for the fix to be that a more advanced Xcode
version check (taking into account alternate Xcode install locations)
is done by MacPorts base; see #12794 . Until such a time as that
is done, we need the code in each portfile, because despite your
statement in #20382  that users should know that they need the
latest Xcode, they demonstrably do not know this. Most of the Xcode
version checks currently in portfiles were added because users
reported that something did not work, and the reason was their Xcode
was too old. To prevent other users from having this issue in the
future, the Xcode version check was added to the ports.
The Xcode version check in these ports is not "faulty"; it merely
does not accommodate nonstandard Xcode install locations. To my
knowledge, MacPorts has never supported nonstandard Xcode install
locations to date, so I think the correct resolution to #20382 for
now is to tell the user to install Xcode in the standard location. Or
if we can come up with new code that uses xcode-select when available
and add that to all the ports that currently check Xcode versions,
that could be a solution too.
More information about the macports-dev