[54368] trunk/base/src/port1.0

[Toby Peterson]

On Sat, Jul 25, 2009 at 17:38, Ryan Schmidt<ryandesign at macports.org> wrote:
>
> On Jul 25, 2009, at 12:03, mcalhoun at macports.org wrote:
>
>> Revision: 54368
>>          http://trac.macports.org/changeset/54368
>> Author:   mcalhoun at macports.org
>> Date:     2009-07-25 10:03:12 -0700 (Sat, 25 Jul 2009)
>> Log Message:
>> -----------
>> Some ports assume that any necessary header and library files are found by
>> default by the compiler (e.g. in /usr/include or /usr/local/include).
>> Changing -I${prefix}/include to -isystem{prefix}/include usually fixes the
>> problem (See r49050, r42207, r49018, r39803, and r47699).
>> Setting environmental variables CPATH and LIBRARY_PATH should make setting
>> -isystem unnecessary.
>> Deleting -I${prefix}/include is only required.
>
> Wait, what? In this commit I see you adding CPATH and LIBRARY_PATH but I
> don't see you deleting the -I and -L stuff. I thought it was an either/or
> thing -- either you use -I and -L or you use CPATH and LIBRARY_PATH. Is that
> not right? How does it all interact if you use all of them at once like
> this? How did you find that this is better than the other proposal of
> changing -I to -isystem?

This change is pretty risky - I think we should do additional testing
before making such a fundamental change to how ports are built.

- Toby