[52257] trunk/dports/math/atlas

[Ryan Schmidt]

On Jun 13, 2009, at 00:10, jameskyle at macports.org wrote:

> Revision: 52257
>           http://trac.macports.org/changeset/52257
> Author:   jameskyle at macports.org
> Date:     2009-06-12 22:10:01 -0700 (Fri, 12 Jun 2009)
> Log Message:
> -----------
> Upgrades atlas to 3.8.3
> Added shared libraries (dylib's)
> Compiles 32 bit libraries for macports compatibility
> Upgrades lapack to 3.2.1
> Proper platform specific optimized build as specified by the math- 
> atlas project
> Fixes misidentification of processor type on intel Core2 processors

Did you have permission from the maintainer of this port to make  
these changes? If a port has a maintainer, as atlas does, you should  
generally file a ticket and attach a patch for the changes you want  
made. If the maintainer does not respond within 72 hours, then you  
can commit the changes. If this is what occurred, then that's fine,  
but you should so indicate in your commit message.


> Modified Paths:
> --------------
>     trunk/dports/math/atlas/Portfile
>
> Added Paths:
> -----------
>     trunk/dports/math/atlas/files/
>     trunk/dports/math/atlas/files/Portfile
>     trunk/dports/math/atlas/files/patch-build-Make.top.diff

There almost certainly should not be a Portfile in the files directory.


> +# the following patch corrects extension conventions for osx's  
> dynamic libs
> +set make_patch      patch-build-Make.top.diff


>  post-configure {
>      # recursively remove directories
>      reinplace "s|rm -f|rm -rf|g" ${workpath}/${name}-${version}/ 
> build/Makefile
> +
> +    # patch ${name}-${version}/build/Make.top to install dynamic libs
> +    system "cd ${worksrcpath}/build/ && \
> +            patch -p0 < ${filespath}/${make_patch}"
>  }

If this patch is only for Mac OS X, it would be best to confine it to  
a "platform darwin" section, so that it does not get applied if  
someone tries to install the port on another operating system  
(unlikely though that might be in MacPorts).

platform darwin {
	post-configure {
		# patch build/Make.top to install dynamic libs
		system "cd ${worksrcpath}/build/ && \
			patch -p0 < ${filespath}/patch-build-Make.top.diff"
	}
}

It looks like this patch stops the software from building static  
libraries, and makes it build Mac OS X dynamic libraries instead, is  
that correct?