[52417] trunk/dports/graphics/nifticlib/Portfile

[Ryan Schmidt]

On Jun 15, 2009, at 23:50, jameskyle at macports.org wrote:

> Revision: 52417
>           http://trac.macports.org/changeset/52417
> Author:   jameskyle at macports.org
> Date:     2009-06-15 21:50:40 -0700 (Mon, 15 Jun 2009)
> Log Message:
> -----------
> Port now suports universal build variant
> Ticket #19419
>
> Modified Paths:
> --------------
>     trunk/dports/graphics/nifticlib/Portfile
>
> Modified: trunk/dports/graphics/nifticlib/Portfile
> ===================================================================
> --- trunk/dports/graphics/nifticlib/Portfile	2009-06-16 04:36:46  
> UTC (rev 52416)
> +++ trunk/dports/graphics/nifticlib/Portfile	2009-06-16 04:50:40  
> UTC (rev 52417)
> @@ -1,17 +1,16 @@
> -# -*- vim: set syn=tcl:
> -# $Id$
> +# vim: set syn=tcl:
>  PortSystem          1.0
>
>  name                nifticlib
>  version             1.1.0
>  categories          graphics science
> -maintainers         ucla.edu:jameskyle
> +maintainers         jameskyle at ucla.edu
>  description         niftilib is a collection of i/o routines for  
> the nifti1 neuroimage data format.
>  long_description    niftilib is a collection of i/o routines for  
> the nifti1 neuroimage data format. C (nifticlib), Java (niftijlib),  
> Matlab (niftimatlib), and Python (pynifti) code is available.  
> Information about the nifti format is available at http:// 
> nifti.nimh.nih.gov/df
>
>  homepage            http://sourceforge.net/projects/niftilib
>  platforms           darwin
> -master_sites        sourceforge:niftilib
> +master_sites        http://dl.sourceforge.net/sourceforge/niftilib/
>  checksums           md5 671c020b3ad54ecdae595983a7d73f79 \
>                      sha1 f1837fa6b99e32f9f80a73ebda56ff5e1e9d6efd \
>                      rmd160 3d70405085b3c432638baa48c71669b1235d385e

You also undid changes blb made before originally committing your port:

http://trac.macports.org/ticket/17932#comment:1

  * Id tag was added
  * maintainers was obfuscated
  * master_sites was simplified

You should redo these changes, and in the future be sure to check the  
"svn diff" to make sure every change you're about to commit is really  
one you want to make and is related to the task you're trying to  
accomplish.


> @@ -21,3 +20,7 @@
>
>  configure.pre_args
>  configure.args -DCMAKE_INSTALL_PREFIX:PATH=${prefix}
> +
> +variant universal description {Build for multiple architectures} {
> +  configure.args-append -DCMAKE_OSX_ARCHITECTURES='ppc\;i386'
> +}

The port should use the set of universal archs the user requested in  
macports.conf instead of assuming that they want ppc i386 (which will  
no longer be the default in MacPorts in Mac OS X 10.6). If you used  
the cmake portgroup I believe this would be handled for you  
automatically, so switching to that portgroup would likely be a good  
idea.