[52668] trunk/dports/security/cyrus-sasl2/Portfile

[Toby Peterson]

On Jun 23, 2009, at 3:51 PM, Joshua Root wrote:

> On 2009-6-24 08:47, Rainer Müller wrote:
>> On 2009-06-21 01:49, toby at macports.org wrote:
>>> --- trunk/dports/security/cyrus-sasl2/Portfile	2009-06-20 23:35:06  
>>> UTC (rev 52667)
>>> +++ trunk/dports/security/cyrus-sasl2/Portfile	2009-06-20 23:49:38  
>>> UTC (rev 52668)
>>> @@ -84,16 +84,14 @@
>>>     file copy ${worksrcpath}/doc ${destroot}${prefix}/share/doc/$ 
>>> {name}
>>> }
>>>
>>> -platform darwin {}
>>> -platform freebsd {}
>>> variant kerberos description "Enable Kerberos support (default)" {
>>>     configure.args-append   --enable-gssapi \
>>>                             --enable-keep-db-open
>>>
>>> -	if {[variant_isset darwin]} {
>>> +	if {${os.platform} == "darwin"} {
>>> 		configure.args-append --with-gss_impl=mit
>>> 	}
>>> -	if {[variant_isset freebsd]} {
>>> +	if {${os.platform} == "freebsd"} {
>>> 		configure.args-append --with-gss_impl=heimdal
>>> 	}
>>> }
>>
>> I think we discussed this before long time ago and agreed to prefer
>> using platform variants in such cases. Otherwise the installed  
>> version
>> does not indicate at all that parts of it are platform specific. With
>> using platform variants, this would have +darwin/+freebsd.
>>
>> At the moment this is not important for most users, but if someone  
>> wants
>> to distribute archives or binaries it will.
>
> Yeah, it's a poor substitute for properly recording platform info in  
> the
> registry and in archive metadata, but it's what we have at present.

I guess I would've been ok with

platform darwin {
     if {[variant_isset kerberos]} {
         configure.args-append --with-gss_impl=mit
     }
}

...

I don't like Portfiles that explicitly acknowledge that platforms are  
actually variants, since that was always a cheap hack. :(

- Toby