[47804] trunk/dports/devel/cmake/Portfile

[Blair Zajac]

On Mar 7, 2009, at 4:48 PM, Ryan Schmidt wrote:

> On Mar 7, 2009, at 17:06, Bryan Blackburn wrote:
>
>> On Sat, Mar 07, 2009 at 05:50:09PM -0500, cssdev at mac.com said:
>>
>>> Could we enable the Trac pre-commit-hook[1] that requires commit  
>>> messages
>>> to reference open tickets? There have been a number of recent  
>>> commits to
>>> ports without references to tickets, and that makes it hard to dig  
>>> through
>>> Trac to find the background info for a particular commit. That's  
>>> annoying
>>> for ports I maintain, especially without either any contact with  
>>> me or
>>> tickets filed in Trac. (There have been some timeouts too, but  
>>> that's part
>>> of the process. :)
>>>
>>> I think we should require port commits to reference existing, open  
>>> Trac
>>> tickets.
>>
>> For all commits?  That would be horrible, then I'd have to create a  
>> ticket
>> every time I wanted to update my own ports as well.
>>
>> For other's ports?  Then the hook would need to be smart, checking
>> maintainers, referencing that against the committer (and some  
>> people may use
>> different accounts), as well as filtering out for openmaintainer...
>>
>> Considering that all you have to do is revert the commit, verses  
>> the amount
>> of work this would entail for something that really doesn't happen  
>> too
>> frequently, doesn't seem like the best choice.
>
> After a little consideration I have to agree with Bryan. There are  
> many times when I want to fix a port's whitespace, or fix a typo in  
> a comment, or make another minor modification for which there's no  
> ticket. Forcing me to make a ticket every time would be annoying. I  
> agree there are some commits that have occurred without tickets  
> where tickets would have been desirable, but I think the  
> disadvantages of using this hook outweigh its benefits for MacPorts.

+1.  A little too much process there.  The commit message should fully  
describe the change if there's no Trac ticket then.

Regards,
Blair

-- 
Blair Zajac, Ph.D.
CTO, OrcaWare Technologies
<blair at orcaware.com>
Subversion training, consulting and support
http://www.orcaware.com/svn/