[48379] trunk/dports/ruby/rb-cocoa/Portfile

[kimura wataru]

Hi, 

(1)configure.args

  append --xcode-extras to configure.args when +xcode is NOT selected.
  I means
----
configure.args      --install-prefix=${destroot}${prefix} \ 
                    --install-root=${destroot} \ 
                    --documentation=${prefix}/share/doc/${name} \ 
                    --examples=${prefix}/share/examples/${name} \ 
        --xcode-extras="${prefix}/share/doc/${name}/project-templates" 

variant xcode description {install project templates for Xcode} {
     configure.args-delete \ 
        --xcode-extras="${prefix}/share/doc/${name}/project-templates" 
} 
----

(2)violate_mtree

  rb-cocoa installes /Library/Frameworks/RubyCocoa.framework
  whether +xcode/-xcode. I think destroot.violate_mtree is needed.

thanks,

On Fri, 20 Mar 2009 12:25:15 -0430, Juan Manuel Palacios wrote:
> 
> On Mar 20, 2009, at 4:43 AM, kimuraw at macports.org wrote:
> 
>> Modified: trunk/dports/ruby/rb-cocoa/Portfile (48378 => 48379)
>> 
>> --- trunk/dports/ruby/rb-cocoa/Portfile	2009-03-20 07:55:52 UTC (rev 48378)
>> +++ trunk/dports/ruby/rb-cocoa/Portfile	2009-03-20 09:13:09 UTC (rev 48379)
>> @@ -32,6 +32,7 @@
>>  					--install-root=${destroot} \
>>  					--documentation=${prefix}/share/doc/${name} \
>>  					--examples=${prefix}/share/examples/${name}
>> +destroot.violate_mtree	yes
>> 
>>  platform darwin 9 {
>>  	if {![variant_isset universal]} {
>> @@ -39,6 +40,13 @@
>>      }
>>  }
>> 
>> +# by default, do not install Xcode templates. #18708
>> +variant xcode description {install project templates for Xcode} { }
>> +if {![variant_isset xcode]} {
>> +	configure.args-append \
>> +		--xcode-extras="${prefix}/share/doc/${name}/project-templates"
>> +}
>> +
>>  post-extract {
>>    system "find \"${worksrcpath}\" -type d -name '.svn' | xargs 
>> /bin/rm -rf"
>>  }
> 
> 
> 	Why put that configure.args modifier line outside the corresponding 
> variant block if it's meant to be called only when the variant is 
> selected? Something like the following should work, unless there's 
> something obvious I'm missing:
> 
> variant xcode description {blah blah blah} {
>     configure.args-append 
> --xcode-extras=${prefix}/share/doc/${name}/project-templates
> }
> 
> 	Also note that I don't use quotes around the argument to the 
> xcode-extras flag, I hardly think they're necessary. Lastly... does 
> that really violate the mtree? I doubt that too, since 
> ${prefix}/share/doc/${name} is within the mtree, if I'm not mistaken.
> 
> 	Regards,...
> 
> 
> -jmpp
> 
-- 
kimura wataru