[48432] trunk/dports/irc/irssi-devel/Portfile

[Rainer Müller]

Ryan Schmidt wrote:
>> It's deprecated if you're running trunk. No warning for 1.7 users.
> 
> Right, and I am suggesting that we remove the deprecation warning for  
> svn.tag from trunk again, and not re-add it until the next version of  
> MacPorts has been released which includes svn.revision. Because  
> svn.tag *is not* deprecated today. svn.tag is in fact the only way to  
> accomplish that today. Nobody, not even those running trunk, should  
> be led to believe that they should replace instances of svn.tag with  
> svn.revision today, because they should not; doing so would break  
> things for those not running trunk.

svn.tag is deprecated on trunk now as it will be in 1.8. I expect
anybody running trunk to follow macports-dev and be aware of these changes.

The deprecation code I implemented keeps the options in sync. That
means for example after setting svn.tag to 42, a read of svn.revision
will give you 42 (works also vice-versa). So Portfiles with svn.tag
still work without problems on trunk, but once 1.8 is released they
should be updated to use svn.revsion instead. It is backwards compatible
to <=1.7 and that is enough in my opinion.

I agree that the warning is a bit annoying, and I did not commit the
livecheck.check -> livecheck.type rename yet because it is even more
talkative. The deprecation warning there appears for nearly all ports,
each time it is parsed. For example on a dependency walk. I will look
into a different approach so the warning will only be displayed on
running 'port lint'. Normal users can't do anything with it anyway.

Rainer