overriding the checksum phase (was: [48686] trunk/dports/databases/libpqxx/Portfile)

[Ryan Schmidt]

On Mar 27, 2009, at 01:02, jmr at macports.org wrote:

> Revision: 48686
>           http://trac.macports.org/changeset/48686
> Author:   jmr at macports.org
> Date:     2009-03-26 23:02:52 -0700 (Thu, 26 Mar 2009)
> Log Message:
> -----------
> libpqxx: don't skip checksum phase (!)
>
> Modified Paths:
> --------------
>     trunk/dports/databases/libpqxx/Portfile
>
> Modified: trunk/dports/databases/libpqxx/Portfile
> ===================================================================
> --- trunk/dports/databases/libpqxx/Portfile	2009-03-27 05:52:14 UTC  
> (rev 48685)
> +++ trunk/dports/databases/libpqxx/Portfile	2009-03-27 06:02:52 UTC  
> (rev 48686)
> @@ -37,8 +37,6 @@
>                  sha1    163d4142015c81a0dc4046fff208d14411532717 \
>                  rmd160  05cd650741fa29174252a4b09b3030911c0ceb95
>
> -checksum        {}


Wouldn't you say that no port should ever override the checksum  
phase? If there are distfiles, their checksums must be validated, and  
if there are no distfiles, then the checksum phase won't get run anyway.

Same with the extract phase.

If we agree, we could add a warning to lint about this.


The following ports block the checksum phase:


$ grep '^checksum[[:space:]]*{[[:space:]]*}' */*/Portfile
databases/postgresql80-server/Portfile:checksum {}
databases/postgresql81-server/Portfile:checksum {}
databases/postgresql82-server/Portfile:checksum {}
databases/postgresql83-server/Portfile:checksum {}
devel/gnome-bindings-csharp/Portfile:checksum        { }
devel/gnome-bindings-cxx/Portfile:checksum        { }
devel/gnome-bindings-perl5/Portfile:checksum        { }
devel/gnome-bindings-python/Portfile:checksum        { }
devel/gnome-bindings-suite/Portfile:checksum        { }
devel/hg-forest/Portfile:checksum            {}
devel/libopensync/Portfile:checksum {}
gnome/colorscheme/Portfile:checksum     {}
gnome/control-center/Portfile:checksum  {}
gnome/gnome-desktop-suite/Portfile:checksum        { }
gnome/gnome-platform-suite/Portfile:checksum        { }
gnome/gnome/Portfile:checksum    { }
gnustep/gnustep-core/Portfile:checksum    { }
gnustep/gnustep/Portfile:checksum    { }
graphics/glut/Portfile:checksum        { }
kde/kde/Portfile:checksum       { }
lang/ghc-devel/Portfile:checksum        { }
lang/perl5/Portfile:checksum {}
lang/smlnj-dev/Portfile:checksum { }
python/py-scipy04/Portfile:checksum        {}
ruby/rb-dbd-mysql/Portfile:checksum {}
ruby/rb-dbd-pg/Portfile:checksum {}
tex/texlive/Portfile:checksum        {}
x11/xorg-apps/Portfile:checksum        { }
x11/xorg-fonts/Portfile:checksum        { }
x11/xorg-proto/Portfile:checksum        { }
x11/xorg/Portfile:checksum        { }
xfce/xfce/Portfile:checksum     { }
$


And we have these ports blocking the extract phase:


$ grep '^extract[[:space:]]*{[[:space:]]*}' */*/Portfile
audio/flac2mp3/Portfile:extract         {}
databases/postgresql80-server/Portfile:extract  {}
databases/postgresql81-server/Portfile:extract  {}
databases/postgresql82-server/Portfile:extract  {}
databases/postgresql83-server/Portfile:extract  {}
devel/cl-ppcre/Portfile:extract   {}
devel/hg-forest/Portfile:extract             {}
devel/libopensync/Portfile:extract {}
graphics/glut/Portfile:extract         { }
lang/ghc-devel/Portfile:extract         { }
lang/lisp-hyperspec/Portfile:extract            { }
lang/perl5/Portfile:extract {}
ruby/rb-dbd-mysql/Portfile:extract {}
ruby/rb-dbd-pg/Portfile:extract {}
sysutils/ccal/Portfile:extract     {}
tex/texlive/Portfile:extract         {}
textproc/psbind/Portfile:extract                { }
x11/xroot/Portfile:extract   {}
$