[51000] trunk/dports/devel

[Frank Schima]

On May 14, 2009, at 9:23 PM, Ryan Schmidt wrote:

> On May 14, 2009, at 22:11, macsforever2000 at macports.org wrote:
>
>> Revision: 51000
>>          http://trac.macports.org/changeset/51000
>> Author:   macsforever2000 at macports.org
>> Date:     2009-05-14 20:11:18 -0700 (Thu, 14 May 2009)
>> Log Message:
>> -----------
>> Added new port. (#19624)
>
>
>
>> +post-patch {
>> +	reinplace "s|-lbluetooth||g" "${worksrcpath}/Commands/Legoctl/
>> Makefile"
>> +	if {${os.major} == 9} {
>> +		reinplace "s|echo -e|echo|g" "${worksrcpath}/Commands/Legoctl/
>> Makefile"
>> +		reinplace "s|echo -e|echo|g" "${worksrcpath}/Commands/Vexctl/
>> Makefile"
>> +		reinplace "s|echo -e|echo|g" "${worksrcpath}/Libs/C/Makefile"
>> +	}
>> +}
>
> FYI, you can simplify this to be a single reinplace command, and you
> don't need quotes around the file paths:
>
>         reinplace "s|echo -e|echo|g" \
>             ${worksrcpath}/Commands/Legoctl/Makefile
>             ${worksrcpath}/Commands/Vexctl/Makefile
>             ${worksrcpath}/Libs/C/Makefile
>
>
> Possibly, this change would be needed on any Darwin version greater
> than or equal to 9, not just on 9. I haven't seen Darwin 10 yet I
> don't know for sure, but my impression was that this change in Darwin
> 9 was intentional, for UNIX compliance, so that change would be
> unlikely to be undone again in a future OS version.
>
>
>> +checksums	 md5 60dcbaea81d06a632493ff0ddb2e0cdc
>> +checksums	 sha1 7c6c84a6bc7328ca95c07f12702387d404d44db1
>> +checksums	 rmd160 a188c924bf4ba01049cb2e0eadc91aeb31f47741
>
> You should probably write this as a single statement:
>
> checksums   md5 60dcbaea81d06a632493ff0ddb2e0cdc \
>             sha1 7c6c84a6bc7328ca95c07f12702387d404d44db1 \
>             rmd160 a188c924bf4ba01049cb2e0eadc91aeb31f47741

Good suggestions. Fixed in r51003.


Cheers!
Frank